Skip to content

fix(cli): validate required parameters in tool call #8598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2025
Merged

fix(cli): validate required parameters in tool call #8598

merged 1 commit into from
Nov 7, 2025

Conversation

@uinstinct
Copy link
Contributor

@uinstinct uinstinct commented Nov 5, 2025 •
edited
Loading

Description

Previously, validateToolCallArgsPresent was iterating over Tool.Parameters instead of Tool.Parameters.properites
This PR fixes that

resolves CON-4775

AI Code Review

  • Team members only: AI review runs automatically when PR is opened or marked ready for review
  • Team members can also trigger a review by commenting @continue-review

Checklist

  • [] I've read the contributing guide
  • [] The relevant docs, if any, have been updated or created
  • [] The relevant tests, if any, have been updated or created

Screen recording or screenshot

before

image

after

image

Tests

[ What tests were added or updated to ensure the changes work as expected? ]

@uinstinct uinstinct requested a review from a team as a code owner November 5, 2025 06:07
@uinstinct uinstinct requested review from sestinj and removed request for a team November 5, 2025 06:07
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 5, 2025
cubic-dev-ai[bot]
cubic-dev-ai bot reviewed Nov 5, 2025
View reviewed changes
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

RomneyDa
RomneyDa approved these changes Nov 7, 2025
View reviewed changes
Copy link
Collaborator

@RomneyDa RomneyDa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uinstinct nice, I missed this when I converted to JSON Schema!

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Nov 7, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 7, 2025
@RomneyDa RomneyDa merged commit cff31cf into continuedev:main Nov 7, 2025
56 of 59 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Nov 7, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2025
@sestinj
Copy link
Contributor

sestinj commented Nov 7, 2025

🎉 This PR is included in version 1.32.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@uinstinct uinstinct deleted the cli-toolargs-validation branch November 8, 2025 11:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

@RomneyDa RomneyDa RomneyDa approved these changes

@sestinj sestinj Awaiting requested review from sestinj sestinj is a code owner automatically assigned from continuedev/continue-code-reviewers

Assignees

No one assigned

Labels

lgtm This PR has been approved by a maintainer released size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Issues and PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@uinstinct @sestinj @RomneyDa